Hi, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes: > On Fri, 29 Jul 2016, Felipe Balbi wrote: > >> slightly unrelated, but... > >> > - maxp = usb_endpoint_maxp(&endpoint->desc) & 0x07ff; >> >> usb_endpoint_maxp() should probably be updated to return only maximum >> packet size. Then we would need to introduce usb_endpoint_mult() or >> something along those lines to take care of the other valid bits. > > Yes, I thought of that too. I didn't want to do it right now because > it would mean auditing all the host controller drivers (and perhaps > checking the device drivers as well). Still, it is a good idea. I have had that in my TODO queue for a few weeks, actually. I need to look at it because of some requirement I found on DWC3 which we're not always guaranteeing. I could do the same thing XHCI did and have its own wrappers, but it's best to fix this once and for all. -- balbi
Attachment:
signature.asc
Description: PGP signature
