Re: [PATCH v2 resend] USB: Driver for Freescale QUICC Engine USB Host Controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 24, 2009 at 01:09:11AM +0300, Anton Vorontsov wrote:
> On Fri, Jan 23, 2009 at 12:56:55PM -0800, Greg KH wrote:
> > On Fri, Jan 23, 2009 at 11:01:14PM +0300, Anton Vorontsov wrote:
> > > On Sat, Jan 10, 2009 at 05:03:21AM +0300, Anton Vorontsov wrote:
> > > > This patch adds support for the FHCI USB controller, as found
> > > > in the Freescale MPC836x and MPC832x processors. It can support
> > > > Full or Low speed modes.
> > > > 
> > > > Quite a lot the hardware is doing by itself (SOF generation, CRC
> > > > generation and checking), though scheduling and retransmission is on
> > > > software's shoulders.
> > > > 
> > > > This controller does not integrate the root hub, so this driver also
> > > > fakes one-port hub. External hub is required to support more than
> > > > one device.
> > > > 
> > > > Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>
> > > > ---
> > > > 
> > > > On Fri, Jan 09, 2009 at 04:51:45PM -0800, Greg KH wrote:
> > > > [...]
> > > > > > This version was superseded by that one:
> > > > > > 
> > > > > > [PATCH v2] USB: Driver for Freescale QUICC Engine USB Host Controller
> > > > > > http://lkml.org/lkml/2008/12/24/80
> > > > > > 
> > > > > > Greg, I can resend it if it's more convenient for you.
> > > > > 
> > > > > Please do, so I know I have the right one.
> > > > 
> > > > Here it is.
> > > 
> > > Hi Greg,
> > > 
> > > Sorry for bothering you again... is there any hope this will be
> > > merged into 2.6.29?
> > 
> > .29?  You sent this to me after the .29 merge window closed for stuff
> > (it needed to be in -next before the window opened.)
> > 
> > It's in my queue, and it is a stand-alone driver
> 
> The driver relied on numerous other patches for other subsystems
> (those patches were in linux-next). Today, of course, it's a
> stand-alone stuff, but indeed because everything else was merged
> _during_ the .29 merge window.
> 
> And since your usb tree is based on Linus' tree, I had to wait for
> those patches go in before asking you to merge the driver itself.
> 
> Is there anything in the work-flow that I could improve next time?

Hm, next time we can add the driver to my tree with a dependancy on
CONFIG_BROKEN.  Then when the other needed parts go in, it would be
simple to remove that dependancy and it would all "just work".

I'll queue this up as it is stand-alone to see if it can go into one of
the next .29-rc releases.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux