Am Mittwoch, 20. Juli 2016, 14:33:25 schrieb Doug Anderson:
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + u2phy0: usb2-phy@e450 {
> > + compatible = "rockchip,rk3399-usb2phy";
> > + reg = <0xe450 0x10>;
> > + clocks = <&cru SCLK_USB2PHY0_REF>;
> > + clock-names = "phyclk";
> > + #clock-cells = <0>;
> > + clock-output-names = "clk_usbphy0_480m";
>
> Any reason why there isn't a 'status = "disabled";' here?
my guess would be, because we might need the provided clock anyway, even in
the case where the actual phy is not used.
But that is better decided by the board/board-dts designer if the clock is
really needed, so add the disabled here and enable in the board, as Doug
suggested.
> > + u2phy0_host: host-port {
> > + #phy-cells = <0>;
> > + interrupts = <GIC_SPI 27
> > IRQ_TYPE_LEVEL_HIGH>; + interrupt-names =
> > "linestate";
> > + status = "disabled";
> > + };
> > + };
> > +
> > + u2phy1: usb2-phy@e460 {
> > + compatible = "rockchip,rk3399-usb2phy";
> > + reg = <0xe460 0x10>;
> > + clocks = <&cru SCLK_USB2PHY1_REF>;
> > + clock-names = "phyclk";
> > + #clock-cells = <0>;
> > + clock-output-names = "clk_usbphy1_480m";
> > +
> > + u2phy1_host: host-port {
> > + #phy-cells = <0>;
> > + interrupts = <GIC_SPI 31
> > IRQ_TYPE_LEVEL_HIGH>; + interrupt-names =
> > "linestate";
> > + status = "disabled";
> > + };
> > + };
> >
> > };
> >
> > watchdog@ff840000 {
> >
> > @@ -1009,5 +1047,12 @@
> >
> > <1 14 RK_FUNC_1 &pcfg_pull_none>;
> >
> > };
> >
> > };
> >
> > +
> > + usb2 {
> > + host_vbus_drv: host-vbus-drv {
> > + rockchip,pins =
> > + <4 25 RK_FUNC_GPIO
> > &pcfg_pull_none>; + };
> > + };
>
> Are you certain this belongs in rk3399.dtsi? It seems like it should
> be in the EVB file.
yep, while most boards follow a reference design, this is still highly board-
specific.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
