Re: [PATCH v2 2/5] usb: serial: removing redundant __func__

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2016-07-15 at 11:35 +0200, Johan Hovold wrote:
> which I find much harder to parse. We don't always enforce a common
> prefix for function names, making grouping related functions even
> harder.
> 
> Usually, what is printed in a debug message only makes sense in
> combination with the function name (e.g. serial_write: 2 bytes), but
> now
> that connection is also less clear.
> 
> Also consider what the above log would look like if you have more than
> one device active. Trying to keep the independent traces separate by
> simply looking at the logs becomes almost impossible. For that reason
> I
> also very much prefer having the device name at the start of the
> message.

You are right. But the correct remedy would be to fix dynamic debugging.
Indeed printing the function before the module is braindead.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux