On Fri, 2016-07-15 at 06:45 +0900, Greg KH wrote:
> On Thu, Jul 14, 2016 at 03:01:41PM +0200, Oliver Neukum wrote:
> > dev_dbg already states the function it is called from. Printing
> > it again is wasted space.
>
> Nope, it's not printed "again", test it and see :)
>
>
echo -n "module usbcore +pf" > /sys/kernel/debug/dynamic_debug/control
[39806.943024] hub_event: hub 3-0:1.0: state 7 ports 15 chg 0000 evt 0040
[39806.943056] hub_port_connect_change: usb usb3-port6: status 0101, change 0001, 12 Mb/s
[39807.099516] hub_port_debounce: usb usb3-port6: debounce total 125ms stable 100ms status 0x101
[39807.211472] usb 3-6: new high-speed USB device number 26 using xhci_hcd
[39807.339929] usb_get_langid: usb 3-6: default language 0x0409
[39807.340368] usb_new_device: usb 3-6: udev 26, busnum 3, minor = 281
[39807.340372] usb 3-6: New USB device found, idVendor=22b8, idProduct=2e62
[39807.340373] usb 3-6: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[39807.340374] usb 3-6: Product: XT1052
[39807.340375] usb 3-6: Manufacturer: motorola
[39807.340376] usb 3-6: SerialNumber: TA64300IE6
[39807.340505] usb_probe_device: usb 3-6: usb_probe_device
[39807.340508] usb_choose_configuration: usb 3-6: configuration #1 chosen from 1 choice
[39807.341226] usb_set_configuration: usb 3-6: adding 3-6:1.0 (config #1, interface 0)
[39807.341421] hub_event: hub 3-0:1.0: state 7 ports 15 chg 0000 evt 0040
[39808.352289] usb 3-6: usbfs: process 2391 (ThreadWeaver::T) did not claim interface 0 before use
[39808.352302] usb_forced_unbind_intf: usbfs 3-6:1.0: forced unbind
[39808.352322] usb_hcd_flush_endpoint: xhci_hcd 0000:00:14.0: shutdown urb ffff8805e5d25840 ep1in-bulk
[39808.467534] usb 3-6: reset high-speed USB device number 26 using xhci_hcd
And the source shows that the function is included:
#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
static struct _ddebug __aligned(8) \
__attribute__((section("__verbose"))) name = { \
.modname = KBUILD_MODNAME, \
.function = __func__, \
.filename = __FILE__, \
.format = (fmt), \
.lineno = __LINE__, \
.flags = _DPRINTK_FLAGS_DEFAULT, \
}
#define dynamic_pr_debug(fmt, ...) \
do { \
DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
if (unlikely(descriptor.flags & _DPRINTK_FLAGS_PRINT)) \
__dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
##__VA_ARGS__); \
} while (0)
#define dynamic_dev_dbg(dev, fmt, ...) \
do { \
DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
if (unlikely(descriptor.flags & _DPRINTK_FLAGS_PRINT)) \
__dynamic_dev_dbg(&descriptor, dev, fmt, \
##__VA_ARGS__); \
} while (0)
Maybe I am dense. Could you elaborate?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
