On Fri, Jan 23, 2009 at 10:36:04AM -0800, David Brownell wrote: > On Friday 23 January 2009, Felipe Balbi wrote: > > On Thu, Jan 08, 2009 at 06:01:36PM +0530, Ajay Kumar Gupta wrote: > > > Mode bit should be set based on function parameter "mode" of > > > configure_channel() function. > > > > > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx> > > > > Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> > > NAK -- interpretation of the MODE parameter is correct > (though it's not clear to me that the callers set it right), > but this won't apply to current GIT since the code differs. hmmm.. don't get what you mean. If mode parameter in channel_program() is true, that means channel->desired_mode should be true and we're trying to kick mode1 dma, isn't it ?? But true, should be re-issued -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html