Hi, Baolin Wang <baolin.wang@xxxxxxxxxx> writes: >> Baolin Wang <baolin.wang@xxxxxxxxxx> writes: >>>> Baolin Wang <baolin.wang@xxxxxxxxxx> writes: >>>>>> Can't you just tie a charger to a UDC and avoid the charger class >>>>>> completely? >>>>> >>>>> Yeah, I also hope so. But we really want something to manage the >>>>> charger devices, do you have any good suggestion to avoid the 'class' >>>>> but also can manage the charger devices? >>>> >>>> manage in what way? It seems to me that they don't need to be real >>>> devices, just a handle as part of struct usb_gadget, no? >>> >>> Although charger device is not one real hardware device, we also use >>> one 'struct device' to describe it in charger.c file. So we should >>> manage the 'struct device' with one proper way. >> >> that's fine, but why do you think they need a struct device to start with? > > We can get/put usb charger and mange usb charger attributes with the > device model if we use a struct device. We already have that as part of struct usb_udc. Why don't you just create a subdirectory called charger which will hold all your charger-related attributes. That directory will only be created if a valid ->charger pointer exists. USB Charging is always tied to a peripheral side controller, anyway. -- balbi
Attachment:
signature.asc
Description: PGP signature
