On 09/06/16 16:58, Felipe Balbi wrote: > > Hi, > > Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> writes: >>> However, if I comment out the phy_exit()/init(), phy_power_off/on() part then >>> I do see the devices resume correctly. >> >> okay, so in some cases we don't want phy_exit()/phy_init(), I can move >> that elsewhere. Let me check. > > wait a minute!! phy_power_off() is done during suspend and has been done > before I touched that. Hmm, it was added by an old patch of mine which > you sent to me recently: > > 5c4ad318de3b usb: dwc3: core: fix PHY handling during suspend > > Are you, now, claiming that's wrong? I'm actually confused now. If that > causes troubles, why was it sent for mainline? Also, I remember I wrote > that to actually fix some other splats that we were having in TI's v4.1 > release. > Don't bother with the PHY now. Just fix the backtrace in device mode. cheers, -roger
Attachment:
signature.asc
Description: OpenPGP digital signature
