Re: [PATCH 23/62] usb: dwc3: implement runtime PM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Roger Quadros <rogerq@xxxxxx> writes:
>> Roger Quadros <rogerq@xxxxxx> writes:
>>>> Roger Quadros <rogerq@xxxxxx> writes:
>>>>> On 30/05/16 14:35, Felipe Balbi wrote:
>>>>>> this patch implements the most basic pm_runtime
>>>>>> support for dwc3. Whenever USB cable is dettached,
>>>>>> then we will allow core to runtime_suspend.
>>>>>>
>>>>>> Runtime suspending will involve completely tearing
>>>>>> down event buffers and require a full soft-reset of
>>>>>> the IP.
>>>>>>
>>>>>> Note that a further optimization could be
>>>>>> implemented once we decide to support hibernation,
>>>>>> which is to allow runtime_suspend with cable
>>>>>> connected when bus is in U3. That's subject to a
>>>>>> separate patch, however.
>>>>>>
>>>>>> Tested-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
>>>>>> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
>>>>>
>>>>> We've discussed this offline but for the record, this patch
>>>>> breaks DWC3 on OMAP platforms. At least on dra7-evm I could see
>>>>> both USB host and gadget breaking.
>>>>>
>>>>> I will try to implement the runtime resume hooks for dwc3-omap
>>>>> and let you know if we can make it work.
>>>>
>>>> cool, thanks :-)
>>>>
>>>
>>> On testing branch commit [1], dwc3 breaks after
>>> system suspend/resume on dra7-evm.
>>>
>>> [1] - cd45299a0f3a41f25729a523aecc0f3e6ad14d43
>> 
>> got some logs there, somewhere? :-)
>> 
> If I'm on commit 9c34239b09894c76fe2f71f1ec8c443a2ae8bf2a

okay. So ENDTRANSFER command failed. Can you capture trace output? Also,
is reverting that enough to keep things working on your side?

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux