> -----Original Message----- > From: Andrew Lunn [mailto:andrew@xxxxxxx] > Sent: Monday, June 6, 2016 9:41 AM > To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx> > Cc: hayeswang@xxxxxxxxxxx; LKML <linux-kernel@xxxxxxxxxxxxxxx>; Netdev > <netdev@xxxxxxxxxxxxxxx>; Linux USB <linux-usb@xxxxxxxxxxxxxxx>; > pali.rohar@xxxxxxxxx; anthony.wong@xxxxxxxxxxxxx; Greg KH > <gregkh@xxxxxxxxxxxxxxxxxxx> > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC > address on RTL8153-AD > > > + /* returns _AUXMAC_#AABBCCDDEEFF# */ > > + status = acpi_evaluate_object(NULL, "\\_SB.AMAC", NULL, &buffer); > > + obj = (union acpi_object *)buffer.pointer; > > + if (ACPI_SUCCESS(status)) { > > + if (obj->type != ACPI_TYPE_BUFFER || > > + obj->string.length != 0x17) { > > + pr_warn("r8152: get_passthru_addr: Invalid buffer"); > > Please don't use pr_warn() when you can use the better alternatives > like dev_warn(). > > Andrew OK thanks, I'll adjust that to use a different warn. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
