Re: OHCI: NULL or LIST_POISON dereference on ueagle-atm disconnection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Try moving the first executable line:
> 
> 	ed->state = ED_OPER;
> 
> to the end of the routine, just before the "return 0;".  That should 
> fix the problem.

Yep, this does the trick. I removed my NULL-check before list_del and
nothing bad happens anymore.

Apparently this bug also prevented scheduling of endpoints which failed
to schedule once in the past. Formerly I was getting only one

usbatm_submit_urb: urb 0xffff8807f1568b00 submission failed (-28)!

from ueagle-atm and now I'm getting regular spam. I think there's good
chance that even on pre-3.18 kernels (which don't crash) iso streams
silently drop data if the first submission fails and the driver retries.

I'll be able to do some functional testing later...
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux