On Tue, Jan 20, 2009 at 01:26:56AM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rjw@xxxxxxx> > > Commit a0d4922da2e4ccb0973095d8d29f36f6b1b5f703 > (USB: fix up suspend and resume for PCI host controllers) attempted > to fix the suspend-resume of PCI USB controllers, but unfortunately > it did that incorrectly and interrupts are left enabled by the USB > controllers' ->suspend_late() callback as a result. This leads to > serious problems during suspend which are very difficult to debug. > > Fix the issue by removing the ->suspend_late() callback of PCI > USB controllers and moving the code from there to the ->suspend() > callback executed with interrupts enabled. Additionally, make > the ->resume() callback of PCI USB controllers execute > pci_enable_wake(dev, PCI_D0, false) to disable wake-up from the > full power state (PCI_D0). > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx> > Tested-by: Andrey Borzenkov <arvidjaar@xxxxxxx> > Tested-by: "Jeff Chua" <jeff.chua.linux@xxxxxxxxx> > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx> > Cc: "Zdenek Kabelac" <zdenek.kabelac@xxxxxxxxx> > Cc: Ingo Molnar <mingo@xxxxxxx> Alan, does this look ok for you? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
