Hi, On 22-05-16 12:39, Tom Yan wrote:
With commit 198de51dbc3454d95b015ca0a055b673f85f01bb, uas no longer set `queue_depth` with scsi_change_queue_depth(), so now `queue_depth` of UAS drives are 1. Even though `can_queue` is set to `devinfo->qdepth - 2`, but apparently that does not help, since I can see performance impact. Suppose limiting `can_queue` is the right way to fix this bug (https://bugzilla.redhat.com/show_bug.cgi?id=1315013), do we really need to eliminate scsi_change_queue_depth() at the same time though?
No, I thought it was no longer needed, assuming the slave would inherit the host's value, but I was mistaken, the slave will default to a queue_depth of 1 if not specified. I'll send out a patch fixing this right away. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html