On 5/18/2016 4:32 AM, Sergei Shtylyov wrote: > Hello. > > On 5/18/2016 2:16 AM, John Youn wrote: > >> From: Vardan Mikayelyan <mvardan@xxxxxxxxxxxx> >> >> According "Table 9-13" of USB2 Specification > > According to. > >> For full-/high-speed isochronous endpoints, bInterval value >> must be in the range from 1 to 16. The bInterval value >> is used as the exponent for a 2^(bInterval-1) value; >> >> Signed-off-by: Vardan Mikayelyan <mvardan@xxxxxxxxxxxx> >> Signed-off-by: John Youn <johnyoun@xxxxxxxxxxxx> >> --- >> drivers/usb/dwc2/core.h | 2 +- >> drivers/usb/dwc2/gadget.c | 11 +++++++---- >> 2 files changed, 8 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h >> index 1b37164..f0d20d6 100644 >> --- a/drivers/usb/dwc2/core.h >> +++ b/drivers/usb/dwc2/core.h > [...] >> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c >> index 7f15bc0..94322e8 100644 >> --- a/drivers/usb/dwc2/gadget.c >> +++ b/drivers/usb/dwc2/gadget.c > [...] >> @@ -2715,6 +2712,12 @@ static int dwc2_hsotg_ep_enable(struct usb_ep *ep, >> if (dir_in) >> hs_ep->periodic = 1; >> >> + if (hsotg->gadget.speed == USB_SPEED_LOW || >> + hsotg->gadget.speed == USB_SPEED_FULL) >> + hs_ep->interval = desc->bInterval; >> + else if (hsotg->gadget.speed == USB_SPEED_HIGH) >> + hs_ep->interval = 1 << (desc->bInterval - 1); >> + > > This is asking to be a *switch* statement. > Thanks, will fix in next version. Regards, John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
