On Tue, 13 Jan 2009, Greg KH wrote: > David and Alan, > > The patch below looks sane to me, do you mind if I clean it up to match > the proper coding guidelines and add it to the tree? > > Saito, thank you very much for doing this work, can you provide a > "Signed-off-by:" line, as documented in the file, > Documentation/SubmittingPatches so that I can apply this patch to the > kernel tree? I have been on vacation and so have not had a chance to review this carefully. However there are a few things about it which could be improved. For example, the comments aren't really accurate. The "three strikes" policy is applied automatically by the hardware; hence the policy added by this patch should be called something else. Also, it's not a good idea to rely on a simple retry counter. Instead of trying three times, it would be better to keep trying for some fixed length of time, like 100 ms. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
