Re: [patch v2] net/usb: remove err() messages in few drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 13 January 2009, Alexey Klimov wrote:
> > Use the interface passed into probe():  dev_err(&intf->dev, ...) etc
> 
> Well, in few v4l-dvb drivers successfully used &radio->usbdev->dev in
> debug messages and that doesn't look wrong.

Use intf->dev ... always.  You may need to save the interface
in probe(), but that's easy.

"Doesn't look wrong" is incorrect; it doesn't list the driver
which issued it.  Which makes it harder to track down exactly
what issued the message, and thence what it really means.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux