Re: [PATCH 118/123] i2400m/SDIO: probe/disconnect, dev init/shutdown and reset backends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 08 January 2009, David Vrabel wrote:
> Greg Kroah-Hartman wrote:
> > From: Inaky Perez-Gonzalez <inaky@xxxxxxxxxxxxxxx>
> >
> > [...]
> > +static
> > +int i2400ms_enable_function(struct sdio_func *func)
> > +{
> > +	u64 timeout;
> > +	int err;
> > +	struct device *dev = &func->dev;
> > +
> > +	d_fnstart(3, dev, "(func %p)\n", func);
> > +	/* Setup timeout (FIXME: This needs to read the CIS table to
> > +	 * get a real timeout) and then wait for the device to signal
> > +	 * it is ready */
> > +	timeout = get_jiffies_64() + ioe_timeout * HZ;
> > +	err = -ENODEV;
> > +	while (err != 0 && time_before64(get_jiffies_64(), timeout)) {
> > +		sdio_claim_host(func);
> > +		err = sdio_enable_func(func);
>
> sdio_enable_func() already polls I/O Ready for the appropriate timeout.

Some models of our device require a gentler push. I will double check with
the HW engineers to see if we can remove the needs for this.

Thanks for the heads up,

-- 
Inaky
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux