Hi, Felipe Ferreri Tonello <eu@xxxxxxxxxxxxxxxxx> writes: >>> On March 5, 2016 4:28:45 PM GMT+00:00, Michal Nazarewicz <mina86@xxxxxxxxxx> wrote: >>>>>> On Wed, Mar 02 2016, Felipe F. Tonello wrote: >>>>>>> @@ -16,7 +16,7 @@ >>>>>>> * Copyright (C) 2006 Thumtronics Pty Ltd. >>>>>>> * Ben Williamson <ben.williamson@xxxxxxxxxxxxxxxxxx> >>>>>>> * >>>>>>> - * Licensed under the GPL-2 or later. >>>>>>> + * Licensed under the GPLv2. >>>> >>>>> On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz >>>> <mina86@xxxxxxxxxx> wrote: >>>>>> Any particular reason to do that? >>>> >>>> On Fri, Mar 04 2016, Felipe Ferreri Tonello wrote: >>>>> Because the kernel is v2 only and not later. >>>> >>>> Linux as a whole is GPLv2 only, but that doesn’t necessarily mean that >>>> parts of it cannot be dual licensed (or GPLv2+). It’s safer to leave >>>> copyright noticed clear unless you explicitly want your contribution be >>>> GPLv2 only which brings the whole file GPLv2 only. >>>> >>>>> I just tried to make this driver more consistent with the coding >>>> style >>>>> used across the kernel. That's it. >>>> >>>> Column alignment of field names or RHS of assignment operators is quite >>>> inconsistent already within drivers/usb/gadget/ which is why I’m >>>> concerned whether this is really helping. >>>> >>>> Anyway, I actually don’t care much, just adding my two rappen. >>> >>> Right, I am ok with Balbi completely ignoring this patch. But I prefer >>> to have at least this driver consistent than nothing. Of course I'll >>> remove the license change I made. >> >> consistent in what way ? > > Source-code. > > The goal of this patch is to update this driver coding style to promote > consistency, readability, and maintainability based on the Linux coding > style. > > If this patch does not achieving that or if that is not necessary, than > just ignore this patch. yeah, I don't think that's what you're doing here. -- balbi
Attachment:
signature.asc
Description: PGP signature
