Re: [PATCH 1/2] usb: dwc3: drop FIFO resizing logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Monday 22 February 2016 02:07 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Kishon Vijay Abraham I <kishon@xxxxxx> writes:
>>>>> On Thursday 04 February 2016 05:48 PM, Felipe Balbi wrote:
>>>>>> That FIFO resizing logic was added to support OMAP5
>>>>>> ES1.0 which had a bogus default FIFO size. I can't
>>>>>> remember the exact size of default FIFO, but it was
>>>>>> less than one bulk superspeed packet (<1024) which
>>>>>> would prevent USB3 from ever working on OMAP5 ES1.0.
>>>>>>
>>>>>> However, OMAP5 ES1.0 support has been dropped by
>>>>>> commit aa2f4b16f830 ("ARM: OMAP5: id: Remove ES1.0
>>>>>> support") which renders FIFO resizing unnecessary.
>>>>>>
>>>>>> Signed-off-by: Felipe Balbi <balbi@xxxxxxxxxx>
>>>>>
>>>>> tested this series on both dra7-evm and dra72-evm using mass storage gadget and
>>>>> msc.sh
>>>>
>>>> both HS and SS ?
>>>
>>> yes.. but the logs here were for only SS.
>>>>
>>>>> dra72-evm: http://pastebin.ubuntu.com/14887997/
>>>>> dra7-evm: http://pastebin.ubuntu.com/14887975/
>>>>>
>>>>> Tested-by: Kishon Vijay Abraham I <kishon@xxxxxx>
>>>>>
>>>>> Let me know if you want me to do any other testing on dra7.
>>>>
>>>> yeah, run testusb for a week or so, that usually catches odd bugs.
>>>
>>> Okay. I'll start the test before I go for vacation next week.
>>
>> Looks like the test couldn't complete and I see dumps [1] in my host
>> PC. Here's the output of testusb [2].
>>
>> [1] -> http://pastebin.ubuntu.com/15169114/
>> [2] -> http://pastebin.ubuntu.com/15169116/
> 
> Does this also happen without this patch applied ?

yeah. I could see that even without the patch.

I think I should update my host PC kernel and check (maybe it got fixed with
the latest xhci driver).

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux