Hi, Petr Kulhavy <petr@xxxxxxxxx> writes: > On 17.02.2016 15:58, Felipe Balbi wrote: >> Hi, >> >> Petr Kulhavy <petr@xxxxxxxxx> writes: >>> This adds two functions to get DT properties "mentor,power" and "dr_mode": >>> musb_get_power() and musb_mode musb_get_mode() >>> >>> Signed-off-by: Petr Kulhavy <petr@xxxxxxxxx> >> seems like I don't have patch 1/5. After fixing Sergei's comments, >> please resend with his Acked-by already in place. >> >> thanks > Hi Felipe, > > I will do as soon as the patch 1/5 gets approved. > It seem to be a bit stuck at the moment as Rob Herring from the DT wants > the "mentor,power" > to be represented as a regulator, whereas Sergei and me want to stick to > the existing "mentor,power" integer property. > > As soon as this get clarified I will do the final updates and send the > patch again. > Maybe this is something you can help to clarify? I don't think that makes sense as a regulator. It's just a number which gets passed to USB Core as is. However, it seems like everything in kernel right now is passing it as 500. So why don't you deprecate that property, hardcode it to 500 and avoid the problem altogether ? The likelihood of new MUSB designs is rather low, anyway. -- balbi
Attachment:
signature.asc
Description: PGP signature
