RE: [PATCH v3 1/2] usbip: vhci number of ports extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > ex) # insmod vhci_hcd.ko num_controllers=4
> 
> I hate module parameters, please don't do that, create these dynamically
> as needed some other way.

OK.

> > Also, ports per controller is changed from 8 to USB_MAXCHILDREN (31).
> 
> Why?  All in one patch?  Not good.

I will remove the modification.

> > It can be modified with VHCI_NPORTS flag at module compilation.
> 
> No one does that, make this dynamic as well please, in a series of patches,
> not just one huge one.

OK.

By the way, how about 2/2.
If it's acceptable, I will post it excluding 1/2.

Thank you,

n.iwata
//
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux