Re: [Patch] net2280.h: fix endpoint max packet for super speed connections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 08, 2016 at 09:51:33PM +0000, Simon Appleby wrote:
> 
> > On 8 Feb 2016, at 16:50, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > On Mon, Feb 08, 2016 at 10:01:09AM +0000, Simon Appleby wrote:
> >> This patch fixes the register offset used for super-speed connection¹s max
> >> packet size.
> >> Without it using the 338x series of devices in enhanced mode will only
> >> allow full or high speed operation to function correctly.
> >> 
> >> 
> >> Signed-off-by: Simon Appleby <simon.appleby@xxxxxxxxxxxxxxxxx>
> >> 
> >> 
> >> --- linux/drivers/usb/gadget/udc/net2280.h.orig 2016-02-08
> >> 09:31:10.000000000 +0000
> >> +++ linux/drivers/usb/gadget/udc/net2280.h      2016-02-08
> >> 09:25:32.000000000 +0000
> >> @@ -369,9 +369,20 @@ static inline void set_max_speed(struct
> >> 	static const u32 ep_enhanced[9] = { 0x10, 0x60, 0x30, 0x80,
> >> 					0x50, 0x20, 0x70, 0x40, 0x90 };
> >> 
> >> - 	if (ep->dev->enhanced_mode)
> >> + 	if (ep->dev->enhanced_mode) {
> >> 		reg = ep_enhanced[ep->num];
> > 
> > Patch is line-wrapped and whitespace corrupted :(
> > 
> 
> 	
> My apologies, first time submitting a patch. Trying with a different client.
> 
> 
> 
> This patch fixes the register offset used for super-speed connection’s max packet size.
> Without it using the 338x series of devices in enhanced mode will only allow full or high speed operation to function correctly.

You need to line-wrap this properly in your commit.

And resend the whole thing, we can't take a patch that we would have to
hand-edit the email in order to apply it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux