Re: [Patch] net2280.h: fix endpoint max packet for super speed connections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 8 Feb 2016, at 16:50, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> On Mon, Feb 08, 2016 at 10:01:09AM +0000, Simon Appleby wrote:
>> This patch fixes the register offset used for super-speed connection¹s max
>> packet size.
>> Without it using the 338x series of devices in enhanced mode will only
>> allow full or high speed operation to function correctly.
>> 
>> 
>> Signed-off-by: Simon Appleby <simon.appleby@xxxxxxxxxxxxxxxxx>
>> 
>> 
>> --- linux/drivers/usb/gadget/udc/net2280.h.orig 2016-02-08
>> 09:31:10.000000000 +0000
>> +++ linux/drivers/usb/gadget/udc/net2280.h      2016-02-08
>> 09:25:32.000000000 +0000
>> @@ -369,9 +369,20 @@ static inline void set_max_speed(struct
>> 	static const u32 ep_enhanced[9] = { 0x10, 0x60, 0x30, 0x80,
>> 					0x50, 0x20, 0x70, 0x40, 0x90 };
>> 
>> - 	if (ep->dev->enhanced_mode)
>> + 	if (ep->dev->enhanced_mode) {
>> 		reg = ep_enhanced[ep->num];
> 
> Patch is line-wrapped and whitespace corrupted :(
> 

	
My apologies, first time submitting a patch. Trying with a different client.



This patch fixes the register offset used for super-speed connection’s max packet size.
Without it using the 338x series of devices in enhanced mode will only allow full or high speed operation to function correctly.

Signed-off-by: Simon Appleby <simon.appleby@xxxxxxxxxxxxxxxxx>

--- linux/drivers/usb/gadget/udc/net2280.h.orig	2016-02-08 09:31:10.000000000 +0000
+++ linux/drivers/usb/gadget/udc/net2280.h	2016-02-08 09:25:32.000000000 +0000
@@ -369,9 +369,20 @@ static inline void set_max_speed(struct 
 	static const u32 ep_enhanced[9] = { 0x10, 0x60, 0x30, 0x80,
 					  0x50, 0x20, 0x70, 0x40, 0x90 };
 
-	if (ep->dev->enhanced_mode)
+	if (ep->dev->enhanced_mode) {
 		reg = ep_enhanced[ep->num];
-	else{
+		switch (ep->dev->gadget.speed) {
+		case USB_SPEED_SUPER:
+			reg += 2;
+			break;
+		case USB_SPEED_FULL:
+			reg += 1;
+			break;
+		case USB_SPEED_HIGH:
+		default:
+			break;
+		}
+	} else {
 		reg = (ep->num + 1) * 0x10;
 		if (ep->dev->gadget.speed != USB_SPEED_HIGH)
 			reg += 1;


______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________
��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux