Hi > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen@xxxxxxxxx] > Sent: Monday, January 25, 2016 3:42 PM > To: Jun Li <jun.li@xxxxxxx> > Cc: Peter Chen <peter.chen@xxxxxxx>; balbi@xxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v5 07/10] usb: chipidea: disable irq while do role > switch > > On Tue, Jan 19, 2016 at 01:45:35PM +0800, Li Jun wrote: > > Since hnp polling will directly invoke otg_statemachine() with irq > > enabled, which will cause nobody cared irq while remove host role for > > B host, so we disable irq for it. > > > > Would you explain more about which interrupt is nobody cared? I cannot reproduce this problem with this series if only remove this patch, so I will drop this patch for now. Li Jun > > > Signed-off-by: Li Jun <jun.li@xxxxxxx> > > --- > > drivers/usb/chipidea/otg_fsm.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/usb/chipidea/otg_fsm.c > > b/drivers/usb/chipidea/otg_fsm.c index cb28e76..e5def6a 100644 > > --- a/drivers/usb/chipidea/otg_fsm.c > > +++ b/drivers/usb/chipidea/otg_fsm.c > > @@ -545,8 +545,10 @@ static int ci_otg_start_host(struct otg_fsm *fsm, > int on) > > ci_role_stop(ci); > > ci_role_start(ci, CI_ROLE_HOST); > > } else { > > + disable_irq(ci->irq); > > ci_role_stop(ci); > > ci_role_start(ci, CI_ROLE_GADGET); > > + enable_irq(ci->irq); > > } > > return 0; > > } > > -- > > 1.9.1 > > > > -- > > Best Regards, > Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
