On Tue, Jan 12, 2016 at 03:10:50PM +0100, Vladis Dronov wrote: > The visor driver crashes in clie_5_attach() when a specially crafted USB > device without bulk-out endpoint is detected. This fix adds a check that > the device has proper configuration expected by the driver. > > Reported-by: Ralf Spenneberg <ralf@xxxxxxxxxxxxxx> > Signed-off-by: Vladis Dronov <vdronov@xxxxxxxxxx> > --- > Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1296466 > > drivers/usb/serial/visor.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c > index 60afb39..bbc90c0 100644 > --- a/drivers/usb/serial/visor.c > +++ b/drivers/usb/serial/visor.c > @@ -597,8 +597,10 @@ static int clie_5_attach(struct usb_serial *serial) > */ > > /* some sanity check */ > - if (serial->num_ports < 2) > - return -1; > + if (serial->num_bulk_out < 2) { > + dev_err(&serial->interface->dev, "missing bulk out endpoints\n"); > + return -ENODEV; > + } > > /* port 0 now uses the modified endpoint Address */ > port = serial->port[0]; Now applied. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
