Re: [PATCH] cdc_acm: blacklist Samsung Phones in firmware update mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2016-01-17 at 10:24 -0200, Jose Alonso wrote:
> On Thu, 2016-01-14 at 14:02 +0100, Oliver Neukum wrote:
> > 
> > > In order to run Heimdall, I think that a better solution would be
> > > to
> > > temporarily "blacklist" the module "cdc_acm".
> > 
> > No. That is no solution. A user may really need cdc-acm.
> > Your work around may cut somebody's connect to the web.
> 
> By temporarily blacklist cdc_acm I mean, "disable cdc_acm during
> firmware update".
> 
> As root user:echo "blacklist cdc_acm" >/etc/modprobe.d/cdc_acm-blacklist.conf
> rmmod cdc_acm # ignore ERROR: is not currently loaded
> ## if module is in use try to disconnect the devices associated.
> 
> plug the usb cable and run Heimdall (normal user)
> 
> at end remove the file /etc/modprobe.d/cdc_acm-blacklist.conf

No, that is an unacceptable work around

1) cdc-acm may already be loaded (or, worse, statically compiled in)
2) the module may be needed for other devices
3) we risk getting into a system state which blocks modems, should
   we lose power

This has to be fixed at the level that makes it always work and
given the information available so far, that is in the kernel.
I am missing confirmation that this ID is specific to the firmware
upload stage of the devices before I use a simple quirk.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux