Re: [PATCH] cdc_acm: blacklist Samsung Phones in firmware update mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jose Alonso <joalonsof@xxxxxxxxx> writes:
> On Thu, 2016-01-14 at 14:02 +0100, Oliver Neukum wrote:
>
>> > In order to run Heimdall, I think that a better solution would be
>> > to
>> > temporarily "blacklist" the module "cdc_acm".
>> 
>> No. That is no solution. A user may really need cdc-acm.
>> Your work around may cut somebody's connect to the web.
>
> By temporarily blacklist cdc_acm I mean, "disable cdc_acm during
> firmware update".
>
> As root user:echo "blacklist cdc_acm" >/etc/modprobe.d/cdc_acm-blacklist.conf
> rmmod cdc_acm # ignore ERROR: is not currently loaded
> ## if module is in use try to disconnect the devices associated.
>
> plug the usb cable and run Heimdall (normal user)
>
> at end remove the file /etc/modprobe.d/cdc_acm-blacklist.conf
> --
> This solution works for all IDs and prevents also the ModemManager
> to probe of the device (there is no device ttyACM*).


Yes, and that's the problem, isn't it? Some of those other devices might
actually need/want cdc-acm and ModemManager while heimdall is working.
It is much better to make the blacklist device specific if we can.  And
the only way you can do that is by patching the driver.

(Currently at least - I did start thinking about ways we could make this
sort of blacklisting implicit and automatic. But concluded that it would
be cause more problems than it would solve. There are very few devices
with this problem)


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux