Re: [PATCH v2] usb: dwc3: gadget: set the OTG flag in dwc3 gadget driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Jianqiang Tang <jianqiang.tang.kernel@xxxxxxxxx> writes:
> This patch is needed in order to pass one test case
> defined in the OTG Automated Compliance Test specification.
>
> Specification location:
> http://www.usb.org/developers/onthego/otgeh_compliance_plan_1_2.pdf
>
> This test case uses PET Tool, and PET Tool is one USB hardware
> equipment provided by MQP Electronics.
>
> Test case id is 6.8.3 B-UUT Bypass Capacitance.
>
> We must set this otg flag in order to be able to return OTG
> descriptor during enumeration, otherwise this test case with
> failed with below error: "Get OTG descriptor request stalled".
>
> Changes since v1:
>         - remove the if () conditional for in favor of a comparison

almost correct. These changes "section" should be below the tearline
(the three dashes below), as I pointed out on previous thread.

> Signed-off-by: Jianqiang Tang <jianqiang.tang@xxxxxxxxx>
> ---
>  drivers/usb/dwc3/gadget.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index a58376f..955122c 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -2748,6 +2748,7 @@ int dwc3_gadget_init(struct dwc3 *dwc)
>  	dwc->gadget.speed		= USB_SPEED_UNKNOWN;
>  	dwc->gadget.sg_supported	= true;
>  	dwc->gadget.name		= "dwc3-gadget";
> +	dwc->gadget.is_otg		= dwc->dr_mode == USB_DR_MODE_OTG;
>  
>  	/*
>  	 * FIXME We might be setting max_speed to <SUPER, however versions
> -- 
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux