Re: [PATCH] usb: ohci: nxp: clean up included header files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 8 Jan 2016, Vladimir Zapolskiy wrote:

> On 09.12.2015 01:10, Vladimir Zapolskiy wrote:
> > On 08.12.2015 17:30, Alan Stern wrote:
> >> On Tue, 8 Dec 2015, Vladimir Zapolskiy wrote:
> >>
> >>> Remove mach/irq.h from the list of included headers, there is no
> >>> compilation dependency on this include file, the change is needed
> >>> to prevent a compilation failure, when mach/irq.h is removed.
> >>>
> >>> Additionally remove other unneeded includes.
> >>>
> >>> Signed-off-by: Vladimir Zapolskiy <vz@xxxxxxxxx>
> >>> ---
> >>>  drivers/usb/host/ohci-nxp.c | 7 -------
> >>>  1 file changed, 7 deletions(-)
> >>>
> >>> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> >>> index cfa9427..ebacf97 100644
> >>> --- a/drivers/usb/host/ohci-nxp.c
> >>> +++ b/drivers/usb/host/ohci-nxp.c
> >>> @@ -22,7 +22,6 @@
> >>>  #include <linux/dma-mapping.h>
> >>>  #include <linux/io.h>
> >>>  #include <linux/i2c.h>
> >>> -#include <linux/kernel.h>
> >>>  #include <linux/module.h>
> >>>  #include <linux/of.h>
> >>>  #include <linux/platform_device.h>
> >>> @@ -32,13 +31,7 @@
> >>>  
> >>>  #include "ohci.h"
> >>>  
> >>> -
> >>>  #include <mach/hardware.h>
> >>> -#include <asm/mach-types.h>
> >>> -#include <asm/io.h>
> >>> -
> >>> -#include <mach/platform.h>
> >>> -#include <mach/irqs.h>
> >>>  
> >>>  #define USB_CONFIG_BASE		0x31020000
> >>>  #define PWRMAN_BASE		0x40004000
> >>
> >> If this still builds correctly, it's okay with me.  I have no way to 
> >> test it.
> > 
> > Thanks for review.
> > 
> > If you have an ARMv5 toolchain, then you can test building with
> > lpc32xx_defconfig:
> > 
> > make ARCH=arm CROSS_COMPILE=${CCPREFIX} lpc32xx_defconfig
> > make ARCH=arm CROSS_COMPILE=${CCPREFIX} drivers/usb/host/ohci-nxp.o
> > 
> 
> Ping.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux