On Thu, 3 Dec 2015, Steinar H. Gunderson wrote: > On Thu, Dec 03, 2015 at 10:37:27AM -0500, Alan Stern wrote: > >> FWIW, I tried against &ps->dev->bus->controller, and it didn't give me any > >> error messages, but still returns NULL. > > I'm at a loss. > > Seemingly controller is already a pointer, so the & is redundant. No idea why > it didn't crash plain out. Fixing that, I can allocate, although I have some > other bug causing an oops somewhere else. Ah, an easy mistake to miss. But you should have gotten a warning from the compiler about incompatible pointer types. > But you still think usb_alloc_coherent() is the better way to go? Should be > easy enough to change, just let me know. Yes, definitely you should use usb_alloc_coherent(). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
