Re: [PATCH] Documentation: nousb is a module parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 10 Nov 2015 14:15:44 +0100,
Oliver Neukum wrote:
> 
> The documentation wrongly implied that it is a core parameter.
> That is not true. If usbcore is compiled as a module, a module
> parameter needs a prefix.

The code drivers/usb/core/usb.c has the following:

/* To disable USB, kernel command line is 'nousb' not 'usbcore.nousb' */
#ifdef MODULE
module_param(nousb, bool, 0444);
#else
core_param(nousb, nousb, bool, 0444);
#endif

... which is quite confusing.

This change was introduced by commit 785895ff1fed
    USB: Don't use __module_param_call; use core_param.

IMO, the current setup is a bad mixture to try keeping some
compatibility while breaking others.  We should either keep "nousb"
always working or unify as a module option.


Takashi

> 
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
> ---
>  Documentation/kernel-parameters.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 22a4b68..a805dff 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -2536,8 +2536,6 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>  
>  	notsc		[BUGS=X86-32] Disable Time Stamp Counter
>  
> -	nousb		[USB] Disable the USB subsystem
> -
>  	nowatchdog	[KNL] Disable both lockup detectors, i.e.
>                          soft-lockup and NMI watchdog (hard-lockup).
>  
> @@ -3852,6 +3850,8 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>                          USB_REQ_GET_DESCRIPTOR request in milliseconds
>  			(default 5000 = 5.0 seconds).
>  
> +	usbcore.nousb	[USB] Disable the USB subsystem
> +
>  	usbhid.mousepoll=
>  			[USBHID] The interval which mice are to be polled at.
>  
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux