Re: [PATCH] usb: storage: scsiglue: increase transfer size limit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 29, 2015 at 4:44 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> That said, I'm pretty sure it's just that there were (and probably
> still are) tons of bad USB sticks with cheap controllers with 8-bit
> sector counts, and you're better off picking something that causes
> fairly even sizes than picking 255.

Side note: it's not necessarily just the cheap usb memory sticks. I
would not be surprised if USB->IDE bridge chipsets etc have a
255-sector limit. The old IDE interfaces contained just a 8-bit sector
count, and while 256 sectors was supposed to work (a sector count of
zero was supposed to mean 256 sectors), there were at least some disks
that got confused and didn't work unless you limited it to 255 sectors
rather than 256.

So I would really suggest strongly that to blindly increase the max
sector field would be rather dangerous. Even if it almost certainly
works fine on any *good* USB storage thing.

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux