On Thu, Oct 29, 2015 at 4:25 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > Fair enough. Linus, do you have any recollection of which device you > found to be quirky ? Your original commit limitting to 240 sectors > doesn't make that clear at all ;-) > > [1] http://marc.info/?l=git-commits-head&m=106945975115131&w=2 Yeah, no, my memory doesn't go that far back, and there's a reason we've made good commit messages more of a priority than it used to be.. That said, I'm pretty sure it's just that there were (and probably still are) tons of bad USB sticks with cheap controllers with 8-bit sector counts, and you're better off picking something that causes fairly even sizes than picking 255. If you really want to increase it and have a good reason to, I suspect it should be limited to known-good (or known-modern) devices some way. Or perhaps make it based on size - if you have a 64GB device the controller is likely higher quality than if you have some el-cheapo 256MB old stick, and you probably have a bigger reason to use large transfer sizes anyway. Or perhaps even just on transfer speed... USB sticks are still sold mainly on price, and while there certainly are other USB storage models than "cheap USB stick", that is still the bulk of it by far. And I'm not at all sure quality has improved all that much at the low end. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
