Re: [PATCH v3 1/4] fs: configfs: Drop unused parameter from configfs_undepend_item()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

[auto build test WARNING on target/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Krzysztof-Opasiak/fs-configfs-Drop-unused-parameter-from-configfs_undepend_item/20151026-232656
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   fs/ocfs2/cluster/nodemanager.c:38:6: sparse: symbol 'o2nm_fence_method_desc' was not declared. Should it be static?
   fs/ocfs2/cluster/nodemanager.c:899:33: sparse: incorrect type in argument 1 (different base types)
   fs/ocfs2/cluster/nodemanager.c:899:33:    expected struct config_item *target
   fs/ocfs2/cluster/nodemanager.c:899:33:    got struct configfs_subsystem static [toplevel] *<noident>
>> fs/ocfs2/cluster/nodemanager.c:899:31: sparse: too many arguments for function configfs_undepend_item
   fs/ocfs2/cluster/nodemanager.c: In function 'o2nm_undepend_item':
   fs/ocfs2/cluster/nodemanager.c:899:25: warning: passing argument 1 of 'configfs_undepend_item' from incompatible pointer type [-Wincompatible-pointer-types]
     configfs_undepend_item(&o2nm_cluster_group.cs_subsys, item);
                            ^
   In file included from fs/ocfs2/cluster/nodemanager.c:25:0:
   include/linux/configfs.h:259:6: note: expected 'struct config_item *' but argument is of type 'struct configfs_subsystem *'
    void configfs_undepend_item(struct config_item *target);
         ^
   fs/ocfs2/cluster/nodemanager.c:899:2: error: too many arguments to function 'configfs_undepend_item'
     configfs_undepend_item(&o2nm_cluster_group.cs_subsys, item);
     ^
   In file included from fs/ocfs2/cluster/nodemanager.c:25:0:
   include/linux/configfs.h:259:6: note: declared here
    void configfs_undepend_item(struct config_item *target);
         ^

vim +899 fs/ocfs2/cluster/nodemanager.c

0c83ed8ee Kurt Hackel 2005-12-15  883  		.su_group = {
0c83ed8ee Kurt Hackel 2005-12-15  884  			.cg_item = {
0c83ed8ee Kurt Hackel 2005-12-15  885  				.ci_namebuf = "cluster",
0c83ed8ee Kurt Hackel 2005-12-15  886  				.ci_type = &o2nm_cluster_group_type,
0c83ed8ee Kurt Hackel 2005-12-15  887  			},
0c83ed8ee Kurt Hackel 2005-12-15  888  		},
0c83ed8ee Kurt Hackel 2005-12-15  889  	},
0c83ed8ee Kurt Hackel 2005-12-15  890  };
0c83ed8ee Kurt Hackel 2005-12-15  891  
14829422b Joel Becker 2007-06-14  892  int o2nm_depend_item(struct config_item *item)
14829422b Joel Becker 2007-06-14  893  {
14829422b Joel Becker 2007-06-14  894  	return configfs_depend_item(&o2nm_cluster_group.cs_subsys, item);
14829422b Joel Becker 2007-06-14  895  }
14829422b Joel Becker 2007-06-14  896  
14829422b Joel Becker 2007-06-14  897  void o2nm_undepend_item(struct config_item *item)
14829422b Joel Becker 2007-06-14  898  {
14829422b Joel Becker 2007-06-14 @899  	configfs_undepend_item(&o2nm_cluster_group.cs_subsys, item);
14829422b Joel Becker 2007-06-14  900  }
14829422b Joel Becker 2007-06-14  901  
16c6a4f24 Joel Becker 2007-06-19  902  int o2nm_depend_this_node(void)
16c6a4f24 Joel Becker 2007-06-19  903  {
16c6a4f24 Joel Becker 2007-06-19  904  	int ret = 0;
16c6a4f24 Joel Becker 2007-06-19  905  	struct o2nm_node *local_node;
16c6a4f24 Joel Becker 2007-06-19  906  
16c6a4f24 Joel Becker 2007-06-19  907  	local_node = o2nm_get_node_by_num(o2nm_this_node());

:::::: The code at line 899 was first introduced by commit
:::::: 14829422be6d6b6721f61b1e749acf5a9cb664d8 ocfs2: Depend on configfs heartbeat items.

:::::: TO: Joel Becker <joel.becker@xxxxxxxxxx>
:::::: CC: Mark Fasheh <mark.fasheh@xxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux