Re: [PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488 spec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 19, 2015 at 09:33:20AM +0200, dave penkler wrote:
> 
> Implement support for the USB488 defined READ_STATUS_BYTE and SRQ
> notifications with ioctl, fasync and poll/select in order to be able
> to synchronize with variable duration instrument operations.
> 
> Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
> LOCAL_LOCKOUT.
> 
> Add convenience ioctl to return all device capabilities.

Can you break this up into a series of patches, all doing only one
thing?  You are doing a lot of different things in this single patch,
making it almost impossible to review :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux