On 20.10.2015 00:11, Luis de Bethencourt wrote: > On 13/10/15 02:49, Krzysztof Kozlowski wrote: >> 2015-10-09 22:00 GMT+09:00 Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>: >>> Since hid_connect() only cares about hiddev_connect() succeeding or >>> failing, there is no need for this function to return an int and it can >>> return a bool instead. >> >> It can return bool but it would not be in line with kernel coding >> style. The hiddev_connect() I believe is an action, so "the function >> should return an error-code integer.". >> >> Best regards, >> Krzysztof >> > > > Hi Krysztof, > > The idea to switch the function to return bool was offered by Jiri Kosina, > as a result of my initial patch changing the return errno code to ENOMEM. I did not see the original comment from Jiri. Actually changing it to ENOMEM makes more sense to me... > > Considering the return isn't propagated by the only consumer of the function, > and your point about returning an integer being the kernel coding style. It > doesn't make sense to change this function. Jiri is the maintainer here but for me sticking to coding convention (return errno) makes it easier to read. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
