Re: [PATCH 2/6] usb: xhci: add Broadcom specific fake doorbell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rafał,

[auto build test WARNING on usb/usb-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Hauke-Mehrtens/usb-bcma-add-USB-3-0-support/20151019-015012
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/usb/host/xhci.c:129:52: sparse: Using plain integer as NULL pointer

vim +129 drivers/usb/host/xhci.c

   113		ret = xhci_handshake(&xhci->op_regs->status,
   114				STS_HALT, STS_HALT, XHCI_MAX_HALT_USEC);
   115		if (!ret) {
   116			xhci->xhc_state |= XHCI_STATE_HALTED;
   117			xhci->cmd_ring_state = CMD_RING_STATE_STOPPED;
   118		} else
   119			xhci_warn(xhci, "Host not halted after %u microseconds.\n",
   120					XHCI_MAX_HALT_USEC);
   121		return ret;
   122	}
   123	
   124	static int xhci_fake_doorbell(struct xhci_hcd *xhci, int slot_id)
   125	{
   126		u32 temp;
   127	
   128		/* alloc a virt device for slot */
 > 129		if (!xhci_alloc_virt_device(xhci, slot_id, 0, GFP_NOIO)) {
   130			xhci_warn(xhci, "Could not allocate xHCI USB device data structures\n");
   131			return -ENOMEM;
   132		}
   133	
   134		/* ring fake doorbell for slot_id ep 0 */
   135		xhci_ring_ep_doorbell(xhci, slot_id, 0, 0);
   136		usleep_range(1000, 1500);
   137	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux