On Mon, Sep 21, 2015 at 05:01:08PM +0200, Peter Senna Tschudin wrote:
> This patch remove NULL checks before calls to dma_pool_destroy() as the
> function now can handle NULL pointers.
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx>
looks good to me
> ---
> drivers/usb/host/fotg210-hcd.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
> index f574143..51feb61 100644
> --- a/drivers/usb/host/fotg210-hcd.c
> +++ b/drivers/usb/host/fotg210-hcd.c
> @@ -1925,17 +1925,13 @@ static void fotg210_mem_cleanup(struct fotg210_hcd *fotg210)
> fotg210->dummy = NULL;
>
> /* DMA consistent memory and pools */
> - if (fotg210->qtd_pool)
> - dma_pool_destroy(fotg210->qtd_pool);
> + dma_pool_destroy(fotg210->qtd_pool);
> fotg210->qtd_pool = NULL;
>
> - if (fotg210->qh_pool) {
> - dma_pool_destroy(fotg210->qh_pool);
> - fotg210->qh_pool = NULL;
> - }
> + dma_pool_destroy(fotg210->qh_pool);
> + fotg210->qh_pool = NULL;
>
> - if (fotg210->itd_pool)
> - dma_pool_destroy(fotg210->itd_pool);
> + dma_pool_destroy(fotg210->itd_pool);
> fotg210->itd_pool = NULL;
>
> if (fotg210->periodic)
> --
> 2.1.0
>
--
balbi
Attachment:
signature.asc
Description: PGP signature
