Hi, On Tue, Sep 15, 2015 at 09:27:20PM +0100, Eric Curtin wrote: > Instead of calling strlen on every iteration of the for loop, just call it > once and cache the result in a temporary local variable which will be used > in the for loop instead. > > Signed-off-by: Eric Curtin <ericcurtin17@xxxxxxxxx> > > diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c > index 05c6d15..9db9d21 100644 > --- a/tools/usb/usbip/src/usbip_detach.c > +++ b/tools/usb/usbip/src/usbip_detach.c > @@ -47,7 +47,9 @@ static int detach_port(char *port) > uint8_t portnum; > char path[PATH_MAX+1]; > The above blank line should be deleted if you declare a new local variable below... > - for (unsigned int i = 0; i < strlen(port); i++) > + unsigned int port_len = strlen(port); > + > + for (unsigned int i = 0; i < port_len; i++) port is read only in this function, so maybe just use "const" and the compiler should know to do the same without adding a new variable? A. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
