Re: [RFC PATCH 1/1] usb: misc: usbtest: add bulk queue test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Sep 2015, Peter Chen wrote:

> The bulk queue tests are used to show 'best performance' for bulk
> transfer, we are often asked this question by users.
> 
> It's result should be very close to IC simulation, in order
> to get that, the device side should also need to prepare enough
> queue.
> 
> We have got the 'best performance' (IN: ~41MB, OUT: ~39MB) at i.mx platform
> (USB2, ARM Cortex A9) with below command:
> 
> Host side:
> modprobe usbtest
> ./testusb -a -t 27 -g 64 -s 16384
> ./testusb -a -t 28 -g 64 -s 16384
> Gadget side:
> modprobe g_zero loopdefault=1 qlen=64 buflen=16384
> 
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> ---
> 
> I am not sure if it is good to reuse iso structure, so I take
> it as RFC. If reuse is accepted, I will rename the iso
> structures to common one.
> 
>  drivers/usb/misc/usbtest.c | 88 ++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 69 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
> index ad6dd4a..f1faeb9 100644
> --- a/drivers/usb/misc/usbtest.c
> +++ b/drivers/usb/misc/usbtest.c
> @@ -17,6 +17,7 @@
>  static int override_alt = -1;
>  module_param_named(alt, override_alt, int, 0644);
>  MODULE_PARM_DESC(alt, ">= 0 to override altsetting selection");
> +static void iso_callback(struct urb *urb);
>  
>  /*-------------------------------------------------------------------------*/
>  
> @@ -239,7 +240,8 @@ static struct urb *usbtest_alloc_urb(
>  	unsigned long		bytes,
>  	unsigned		transfer_flags,
>  	unsigned		offset,
> -	u8			bInterval)
> +	u8			bInterval,
> +	bool			queue_callback)

Should this be named "is_iso" instead?  It would be be more clear.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux