Re: [PATCH 2/7] usb: misc: usbtest: delete useless memset for urbs array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 28 2015, Peter Chen wrote:
> The element of urbs array will be initialized at below code
> at once.
>
> 	for (i = 0; i < param->sglen; i++) {
> 		urbs[i] = iso_alloc_urb(udev, pipe, desc,
> 					param->length, offset);
>
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

> ---
>  drivers/usb/misc/usbtest.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
> index 9cdb4ad..ed0ca53 100644
> --- a/drivers/usb/misc/usbtest.c
> +++ b/drivers/usb/misc/usbtest.c
> @@ -1919,7 +1919,6 @@ test_iso_queue(struct usbtest_dev *dev, struct usbtest_param *param,
>  	init_completion(&context.done);
>  	spin_lock_init(&context.lock);
>  
> -	memset(urbs, 0, sizeof(urbs));
>  	udev = testdev_to_usbdev(dev);
>  	dev_info(&dev->intf->dev,
>  		"iso period %d %sframes, wMaxPacket %d, transactions: %d\n",
> -- 
> 1.9.1
>

-- 
Best regards,                                            _     _
.o. | Liege of Serenely Enlightened Majesty of         o' \,=./ `o
..o | Computer Science,  ミハウ “mina86” ナザレヴイツ  (o o)
ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux