On Fri, Aug 28 2015, Peter Chen wrote: > Allocate the size of urb pointer array according to testusb's > parameter sglen. > > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx> I vaguely recall that LLVM fans got mad last time I used dynamically sized local arrays though. Not sure though, I may be misremembering things. > --- > drivers/usb/misc/usbtest.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c > index 9517812..9cdb4ad 100644 > --- a/drivers/usb/misc/usbtest.c > +++ b/drivers/usb/misc/usbtest.c > @@ -1911,10 +1911,7 @@ test_iso_queue(struct usbtest_dev *dev, struct usbtest_param *param, > unsigned i; > unsigned long packets = 0; > int status = 0; > - struct urb *urbs[10]; /* FIXME no limit */ > - > - if (param->sglen > 10) > - return -EDOM; > + struct urb *urbs[param->sglen]; > > memset(&context, 0, sizeof(context)); > context.count = param->iterations * param->sglen; > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, ミハウ “mina86” ナザレヴイツ (o o) ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>-----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
