lyz, On Tue, Aug 18, 2015 at 2:40 AM, Yunzhi Li <lyz@xxxxxxxxxxxxxx> wrote: > We initiate dwc2 usb controller in BIOS, dwc2_core_reset() should > be called before dwc2_get_hwparams() to reset core registers to > default value. Without this the FIFO setting might be incorrect > because calculating FIFO size need power-on value of > GRXFSIZ/GNPTXFSIZ/HPTXFSIZ registers. > > This patch could avoid warnning massage like in rk3288 platform: > [ 2.074764] dwc2 ff580000.usb: 256 invalid for > host_perio_tx_fifo_size. Check HW configuration. > > Signed-off-by: Yunzhi Li <lyz@xxxxxxxxxxxxxx> > > --- > > drivers/usb/dwc2/core.c | 2 +- > drivers/usb/dwc2/core.h | 1 + > drivers/usb/dwc2/platform.c | 6 ++++++ > 3 files changed, 8 insertions(+), 1 deletion(-) This seems reasonable to me. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html