Re: [PATCH RESEND] usbhid: Fix the check for HID_RESET_PENDING in hid_io_error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 10 Aug 2015, Don Zickus wrote:

> It was reported that after 10-20 reboots, a usb keyboard plugged
> into a docking station would not work unless it was replugged in.
> 
> Using usbmon, it turns out the interrupt URBs were streaming with
> callback errors of -71 for some reason.  The hid-core.c::hid_io_error was
> supposed to retry and then reset, but the reset wasn't really happening.
> 
> The check for HID_NO_BANDWIDTH was inverted.  Fix was simple.
> 
> Tested by reporter and locally by me by unplugging a keyboard halfway until I
> could recreate a stream of errors but no disconnect.
> 
> Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx>
> ---
> 
> I mistyped the usb mailing list address, so this patch never made it there.
> Resending with the correct address.  Sorry for the spam.

Hmm, good catch.

I've added Cc: stable and applied to for-4.3/upstream.

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux