Arnd, On 08/14/2015 04:19 PM, Arnd Bergmann wrote:
On Wednesday 12 August 2015 16:51:29 Jeremy Linton wrote:diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c index 2593def..82e396f 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c @@ -162,8 +162,10 @@ static int ehci_platform_probe(struct platform_device *dev) err = dma_coerce_mask_and_coherent(&dev->dev, pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32)); - if (err) + if (err) { + dev_err(&dev->dev, "Error: DMA setup failed\n"); return err; + }We should really stop doing this: the platform should provide the correct dma mask when creating the device, instead of setting a bogus pdata field. Do not duplicate this bug for ACPI.
I'm not sure I understand, I'm not changing the mask anywhere, all I'm doing is printing a message if the mask cannot be set.
AKA if CCA is missing or set to 0 then, this line is triggered because the dma_coerce_mask_and_coherent() routine returns with a failure indicating there aren't any DMA ops to set a mask on. Right now what happens is the device detection displays that there is an EHCI controller then silently disappears with telling the user why it didn't configure.
Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
