Re: [PATCH] da8xx musb: add device tree support

[Felipe Balbi <balbi@xxxxxx>]

Hi,

On Thu, Jul 23, 2015 at 04:19:06PM +0000, Andrew Holcomb wrote:
> Attached is a patch that adds device tree support to the da8xx musb driver.  The current driver expects a board file to setup the platform device and perform the initialization. With this patch all of the setup is done through the device tree.
> 
> diffstat for this patch is:
> Documentation/devicetree/bindings/usb/da8xx-usb.txt |   18 ++
> drivers/usb/musb/Kconfig                            |    1
> drivers/usb/musb/da8xx.c                            |  139 ++++++++++++++------
> 3 files changed, 119 insertions(+), 39 deletions(-)
> 
> To apply this patch, in the root of a kernel tree use:
> patch -p1 < da8xx-musb.patch
> 
> Please let me know any feedback you have on this patch.
> 
> Thanks
> 
> Andrew Holcomb
> Software Engineer
> RELM Wireless
> 
> Signed-off-by: Andrew T Holcomb <aholcomb@xxxxxxxxxx<mailto:aholcomb@xxxxxxxxxx>>
> 
> ----------------------------------------------------------------------------------------------------------------
> diff -pruN linux-4.1/Documentation/devicetree/bindings/usb/da8xx-usb.txt linux-4.1.musb/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> --- linux-4.1/Documentation/devicetree/bindings/usb/da8xx-usb.txt 1969-12-31 18:00:00.000000000 -0600
> +++ linux-4.1.musb/Documentation/devicetree/bindings/usb/da8xx-usb.txt 2015-07-23 10:49:35.926160500 -0500
> @@ -0,0 +1,18 @@
> +DA8XX MUSB
> +
> +Required properties:
> + - compatible : Should be "ti,da8xx-musb"
> + - reg        : Offset and length of registers
> + - interrupts : Interrupt number
> + - mode       : Dual-role; either host mode "host", peripheral mode "peripheral"
> +                or both "otg"
> +
> +Example:
> +
> +musb@1e00000<mailto:+musb@1e00000> {
> + compatible = "ti,da8xx-musb";
> + reg = <0x01e00000 0x10000>;
> + interrupts = <58>;
> + interrupt-names = "mc";
> + mode = "peripheral";
> +};
> diff -pruN linux-4.1/drivers/usb/musb/da8xx.c linux-4.1.musb/drivers/usb/musb/da8xx.c
> --- linux-4.1/drivers/usb/musb/da8xx.c 2015-06-22 00:05:43.000000000 -0500
> +++ linux-4.1.musb/drivers/usb/musb/da8xx.c 2015-07-23 10:49:35.926160500 -0500
> @@ -89,6 +89,36 @@ struct da8xx_glue {
>   struct clk  *clk;
>  };
> 
> +static struct musb_hdrc_eps_bits musb_eps[] = {
> +        { "ep1_tx", 8, },

patch's mangled. Sorry, can't apply.

-- 
balbi

Attachment: signature.asc
Description: Digital signature