Just a few nits, I'm afraid.
On di, 2015-07-14 at 11:13 +0800, Peter Hung wrote:
> --- /dev/null
> +++ b/drivers/usb/serial/f81534.c
> +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset)
> +{
> + [...]
> +}
static?
> +void f81534_gpio_free(struct gpio_chip *chip, unsigned offset)
> +{
> + [...]
> +}
Ditto.
> +static struct gpio_chip f81534_gpio_chip_templete = {
> + [...]
> + .request = f81534_gpio_request,
> + .free = f81534_gpio_free,
> + [...]
> +};
> +int f81534_ioctl_set_rs485(struct usb_serial_port *port,
> + struct serial_rs485 __user *arg)
> +{
> + [...]
> +}
Ditto.
> +static int f81534_ioctl(struct tty_struct *tty, unsigned int cmd,
> + unsigned long arg)
> +{
> + [...]
> + case TIOCSRS485:
> + return f81534_ioctl_set_rs485(port,
> + (struct serial_rs485 __user *)
> + arg);
> + [...]
> +}
> +int f81534_prepare_write_buffer(struct usb_serial_port *port,
> + void *dest, size_t size)
> +{
> + [...]
> +}
Ditto.
> +static struct usb_serial_driver f81534_device = {
> + [...]
> + .prepare_write_buffer = f81534_prepare_write_buffer,
> + .[...]
> +};
> +
> +static struct usb_serial_driver *const serial_drivers[] = {
> + &f81534_device, NULL
> +};
> +
If you drop this empty line ...
> +module_usb_serial_driver(serial_drivers, id_table);
and add an empty line here, things look neater.
> +MODULE_DESCRIPTION(DRIVER_DESC);
> +MODULE_AUTHOR("Peter Hong <Peter_Hong@xxxxxxxxxxxxx>");
> +MODULE_AUTHOR("Tom Tsai <Tom_Tsai@xxxxxxxxxxxxx>");
> +MODULE_LICENSE("GPL");
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
