Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2015-07-15 16:29 GMT+08:00 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>:
> Hello,
>
> On Wed, Jul 15, 2015 at 01:45:44PM +0530, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Wednesday 15 July 2015 12:34 PM, Axel Lin wrote:
>> > 2015-06-20 15:39 GMT+08:00 Axel Lin <axel.lin@xxxxxxxxxx>:
>> >> Also simplify the code a bit by specify direction and initial value for
>> >> output in devm_gpiod_get_optional function.
>> >>
>> >> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
>> >> Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>> >> Acked-by: Kishon Vijay Abraham I <kishon@xxxxxx>
>> >> ---
>> >> Hi
>> >> This patch was sent on https://lkml.org/lkml/2015/5/31/221 with ACKs.
>> >> It's still not in linux-next, so here is a resend.
>> >
>> > Hi Kishon,
>> > No response from Felipe.
>> > The phy-tusb1210 driver is already in Linus' tree, maybe you can pick
>> > up this patch.
>>
>> A similar patch was done by Uwe [1]. But since you've sent this patch before
>> Uwe, IMO your patch must be merged.
>>
>> Uwe,
>> How do you want this patch to be merged. Is it okay If I take this in PHY tree?
>> Can you give your Acked-by?
> I intend to change the gpiod functions to make the flags mandatory
> for 4.3. I already sent the respective change to Linus Walleij to pull
> for next and my commit to fix phy-tusb1210 is included to not break this
> driver.

I'm fine to just apply Uwe's patch if it make things easier.

Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux