On Wed, 17 Jun 2015, Stefan Koch wrote:
> Am Mittwoch, den 17.06.2015, 11:11 -0400 schrieb Alan Stern:
> > On Wed, 17 Jun 2015, Stefan Koch wrote:
> >
> > > Interfaces are allowed per default.
> > > This can disabled or enabled (again) by writing 0 or 1 to
> > > /sys/bus/usb/devices/usb*/interface_authorized_default
> > >
> > > Signed-off-by: Stefan Koch <skoch@xxxxxxx>
> >
> > > --- a/include/linux/usb/hcd.h
> > > +++ b/include/linux/usb/hcd.h
> > > @@ -142,6 +142,7 @@ struct usb_hcd {
> > > unsigned uses_new_polling:1;
> > > unsigned wireless:1; /* Wireless USB HCD */
> > > unsigned authorized_default:1;
> > > + unsigned interface_authorized_default:1;
> >
> > This is the wrong place to put your new flag. This section is for
> > flags that get set only during HCD registration or removal (see the
> > comment on line 134).
> What would be the best place? (The authorized_default is here, too)
They both should be part of hcd->flags. (The comment on lines 62-66 of
this file doesn't seem to belong either, and it will be incorrect after
your patch.)
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
