Re: [PATCH v3 3/6] usb: interface authorization: Control interface probing and claiming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 17 Jun 2015, Stefan Koch wrote:

> Driver probings and interface claims get rejected
> if an interface is not authorized.
> 
> Signed-off-by: Stefan Koch <skoch@xxxxxxx>
> ---
>  drivers/base/base.h       |  1 -
>  drivers/usb/core/driver.c | 11 +++++++++++
>  include/linux/device.h    |  1 +

This patch shouldn't modify drivers/base/base.h or 
include/linux/device.h.

> --- a/drivers/usb/core/driver.c
> +++ b/drivers/usb/core/driver.c
> @@ -295,6 +295,13 @@ static int usb_probe_interface(struct device *dev)
>  	if (udev->authorized == 0) {
>  		dev_err(&intf->dev, "Device is not authorized for usage\n");
>  		return error;
> +	} else if (intf->authorized == 0) {
> +		unsigned intfNr = intf->altsetting->desc.bInterfaceNumber;

Please name this variable intf_num or something like that.  Don't use 
CamelCase.

Or get rid of the variable entirely and put 
intf->altsetting->desc.bInterfaceNumber directly into the dev_err() 
call below.

> +
> +		dev_err(&intf->dev, "Interface 0x%02x is not authorized for usage\n",
> +				intfNr);
> +
> +		return error;
>  	}
>  
>  	id = usb_match_dynamic_id(intf, driver);

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux